Skip to content

Create Event in case of OOBM failure#4418

Merged
DaanHoogland merged 2 commits intoapache:masterfrom
CLDIN:event-powerstatus-fail
Nov 10, 2020
Merged

Create Event in case of OOBM failure#4418
DaanHoogland merged 2 commits intoapache:masterfrom
CLDIN:event-powerstatus-fail

Conversation

@GabrielBrascher
Copy link
Member

@GabrielBrascher GabrielBrascher commented Oct 21, 2020 •
edited
Loading

Description

Out of band power operations are constantly issued to assess the host power status. However, if such actions fail the Admins receive a warning message on the log. In order to help Admins to easily track such failures, this PR creates an Event each time an Out-of-band power operation fails.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

@GabrielBrascher GabrielBrascher self-assigned this Oct 21, 2020
@GabrielBrascher GabrielBrascher changed the title Create EVENT in case of oobm failure Create Event in case of OOBM failure Oct 21, 2020
@wido wido self-requested a review October 22, 2020 07:02
wido
wido reviewed Oct 22, 2020
View reviewed changes
@GabrielBrascher GabrielBrascher marked this pull request as ready for review October 22, 2020 17:19
@GabrielBrascher
Copy link
Member Author

GabrielBrascher commented Oct 22, 2020

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Oct 22, 2020

@GabrielBrascher a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@GabrielBrascher
Copy link
Member Author

GabrielBrascher commented Oct 22, 2020

@DaanHoogland I took the liberty to aim this one to 4.15.
Please let me know if this one is getting too late then I move it to 4.16 ;)

@GabrielBrascher GabrielBrascher added this to the 4.15.0.0 milestone Oct 22, 2020
@blueorangutan
Copy link

blueorangutan commented Oct 22, 2020

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2265

@DaanHoogland
Copy link
Contributor

DaanHoogland commented Oct 22, 2020

no tests added but for regression,
@blueorangutan test

@blueorangutan
Copy link

blueorangutan commented Oct 22, 2020

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

blueorangutan commented Oct 23, 2020

Trillian test result (tid-3058)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 38046 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4418-t3058-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 84 look OK, 1 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL Failure 315.93 test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers Failure 302.26 test_vpc_redundant.py

yadvr
yadvr approved these changes Oct 28, 2020
View reviewed changes
Copy link
Member

@yadvr yadvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - did not test it

@yadvr yadvr requested review from DaanHoogland and wido November 2, 2020 08:40
wido
wido approved these changes Nov 2, 2020
View reviewed changes
Copy link
Contributor

@wido wido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Admins should be notified if CloudStack can't reach the OOB of a node. As this will be used not very often it's good that CloudStack keeps testing the reachability of the OOB so that when it's needed it also works.

@GabrielBrascher
Copy link
Member Author

GabrielBrascher commented Nov 2, 2020

@rhtyd @DaanHoogland @wido @PaulAngus here follows a screenshot with the warning events:
image

@PaulAngus PaulAngus removed the type:bug label Nov 3, 2020
@DaanHoogland
Copy link
Contributor

DaanHoogland commented Nov 4, 2020

@PaulAngus can we put this in for 4.15?

@DaanHoogland
Copy link
Contributor

DaanHoogland commented Nov 10, 2020

@PaulAngus very small and meets all criteria, merging

@DaanHoogland DaanHoogland merged commit 823111d into apache:master Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes

@wido wido wido approved these changes

@DaanHoogland DaanHoogland Awaiting requested review from DaanHoogland

Assignees

@GabrielBrascher GabrielBrascher

Labels

Severity:Minor type:enhancement

Projects

None yet

Milestone

4.15.0.0

Development

Successfully merging this pull request may close these issues.

7 participants

@GabrielBrascher @blueorangutan @DaanHoogland @yadvr @wido @PaulAngus @ACSGitBot